Microsoft.Billing and Microsoft.Consumption swagger changes for GTM (DoNotMerge) by sandeepkatumalla · Pull Request #4484 · Azure/azure-rest-api-specs

sandeepkatumalla · 2018-11-15T22:39:08Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

Adding Lots to Consumption RP

Add pricesheet download api to Microsoft.Billing

… checks errors)

…st-api-specs

… what we need

AutorestCI · 2018-11-15T22:40:05Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1175cb2b1474a553d64c0f0b846b41224a5c2cdd
  stderr: 'fatal: reference is not a tree: 1175cb2b1474a553d64c0f0b846b41224a5c2cdd'

AutorestCI · 2018-11-15T22:40:07Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1175cb2b1474a553d64c0f0b846b41224a5c2cdd
  stderr: 'fatal: reference is not a tree: 1175cb2b1474a553d64c0f0b846b41224a5c2cdd'

AutorestCI · 2018-11-15T22:42:26Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1175cb2b1474a553d64c0f0b846b41224a5c2cdd
  stderr: 'fatal: reference is not a tree: 1175cb2b1474a553d64c0f0b846b41224a5c2cdd'

dsgouda · 2018-11-15T23:03:35Z

Working on some high pri NET sdk deliverables, reassigning

.../Microsoft.Billing/preview/2018-11-01-preview/examples/AvailableBalanceByBillingProfile.json

+{
+  "parameters": {
+    "api-version": "2018-11-01-preview",
+    "billingAccountId": "04e9d123-ae03-5621-6c17-e70da00924ee",


wilcobmsft · 2018-11-16T00:36:03Z

...g/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/BillingAccount.json

+          "company": "Test Account",
+          "accountType": "Organization",
+          "address": {
+            "AddressLine1": "Test Address",


camelCasing everywhere

wilcobmsft · 2018-11-16T00:37:23Z

...anager/Microsoft.Billing/preview/2018-11-01-preview/examples/BillingAccountInvoicesList.json

+            }
+          },
+          {
+            "id": "providers/Microsoft.Billing/billingAccounts/2000200/billingProfile/345987/invoices/1383724",


Let's be consistent in whether we prefix the id with a "/". I'm seeing two conventions in this PR.

wilcobmsft · 2018-11-16T00:39:11Z

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateInvoiceSection.json

+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/invoiceSections/operationResults/ed2975a8-8f77-43bb-a717-ace54326b14b?api-version=2018-07-31",
+        "Retry-After": "60",


Retry-After needs to be an integer, not a string

wilcobmsft · 2018-11-16T00:43:16Z

.../billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/Product.json

+          "name": "productSummaryId1",
+          "type": "Microsoft.Consumption/products",
+          "properties": {
+            "productTypeId": "A12345",


Having a property "productTypeId" and "productType" implies the latter is an actual (expanded) resource. I believe it's simply a localized name, in which case I'd argue productType should be called e.g. productTypeName.

wilcobmsft · 2018-11-16T00:50:27Z

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateInvoiceSection.json

+    "billingAccountId": "{billingAccountId}",
+    "parameters": {
+      "request": {
+        "displayName": "invoiceSectionName1",


displayName/billingProfileId should be nested in a "properties" object?

jhendrixMSFT

Please take a look at the model validation failures here. These will need to be fixed.

jhendrixMSFT · 2018-11-16T16:51:40Z

@sandeepkatumalla has this new API version been reviewed by ARM?

sandeepkatumalla · 2018-11-16T16:57:25Z

We have a review scheduled in 5 minutes with Arm

…

On Fri, Nov 16, 2018, 08:51 Joel Hendrix ***@***.*** wrote: @sandeepkatumalla <https://github.com/sandeepkatumalla> has this new API version been reviewed by ARM? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4484 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmmKJP4tinDn7SLuOjC3Txi84sOeTZwIks5uvu0tgaJpZM4YjazK> .

ravbhatnagar · 2018-11-20T00:30:28Z

Signing off from ARM side. Only thing in contention looked to be billingProperty - name of this entity is confusing and does not clarify what info the user can expect from this resource. Also, this does not seem to be a resource as it does not have the id, name and type properties. Is this a singleton? If yes, may be we could have had the name as "default". else if could have been modeled as a POST. POST .../Microsoft.Billing/listBillingProperties. And that would have allowed to make it possible to have any shape for the response (without having to include id, name and type)

ravbhatnagar · 2018-11-20T00:31:02Z

@sandeepkatumalla FYI

muazmian · 2018-11-21T23:01:01Z

...g/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/BillingAccount.json

+          "displayName": "Test Account",
+          "company": "Test Account",
+          "accountType": "Organization",
+          "address": {


address is being returned as billingAddress in API response

jhendrixMSFT · 2018-11-30T20:29:21Z

@sandeepkatumalla any update?

sandeepkatumalla · 2018-11-30T20:57:32Z

Please go ahead and close this. We already have our manifest reviewed and approved. When going GA, we'll come up with a fresh review.

…

On Fri, Nov 30, 2018 at 12:29 PM Joel Hendrix ***@***.***> wrote: @sandeepkatumalla <https://github.com/sandeepkatumalla> any update? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4484 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmmKJGihZWA9WWtIkXx_L6SKghOp0CJaks5u0ZUugaJpZM4YjazK> .

Sandeep Katumalla and others added 24 commits September 20, 2018 15:40

Adding Lots to Consumption RP

5742b8f

Adding Lots to Consumption RP

Add pricesheet download api to Microsoft.Billing

994490b

Add pricesheet download api to Microsoft.Billing

Adding missing types

b822b3a

defining single use parameters inline

16233c2

Adding missing files (unrelated to this commit but need to get rid of…

14fe81a

… checks errors)

Delete consumption.json

3bb8827

Removing unnecessary files

e5ddd11

Merge branch 'master' of https://github.com/sandeepkatumalla/azure-re…

e16a1a5

…st-api-specs

Delete LotsListByBillingProfile.json

28d8d06

Removing additional /

607fc99

Merge branch 'master' of https://github.com/sandeepkatumalla/azure-re…

6a62632

…st-api-specs

changing tag to pricesheet

eb84d6d

Update x-ms-examples key

03fd7f3

Fixing conflict

c3a339b

fixing warning

0a5aa3e

Noting it as a long running operation

e01b483

removing long running operation since it doesn't support GET which is…

3257ef2

… what we need

Feedback from ARM

f6575e2

nit: minor spelling checks

68c62da

nit: fixing operationId warning

2f24998

nit: fixes and examples

b8da71c

fixing format

fd4787e

Microsoft.Billing swagger changes for GTM

2a1aa3f

Microsoft.Consumption swagger changes for GTM

40ca1ee

AutorestCI mentioned this pull request Nov 15, 2018

[AutoPR billing/resource-manager/consumption/resource-manager] Microsoft.Billing and Microsoft.Consumption swagger changes for GTM Azure/azure-sdk-for-js#508

Closed

AutorestCI mentioned this pull request Nov 15, 2018

[AutoPR consumption/resource-manager/billing/resource-manager] Microsoft.Billing and Microsoft.Consumption swagger changes for GTM Azure/azure-sdk-for-python#3803

Closed

azuresdkci assigned dsgouda Nov 15, 2018

azuresdkci requested a review from dsgouda November 15, 2018 22:40

AutorestCI mentioned this pull request Nov 15, 2018

[AutoPR billing/resource-manager/consumption/resource-manager] Microsoft.Billing and Microsoft.Consumption swagger changes for GTM Azure/azure-sdk-for-go#3312

Closed

Delete previous version from PR

63f6a23

dsgouda added the Reassign label Nov 15, 2018

Sandeep Katumalla added 2 commits November 15, 2018 15:24

adding back billing.json

2d73cd5

Removing pricesheet from old version

6680ff6

azuresdkci removed the Reassign label Nov 15, 2018

azuresdkci assigned jhendrixMSFT and unassigned dsgouda Nov 15, 2018

azuresdkci requested a review from jhendrixMSFT November 15, 2018 23:36

sandeepkatumalla changed the title ~~Microsoft.Billing and Microsoft.Consumption swagger changes for GTM~~ Microsoft.Billing and Microsoft.Consumption swagger changes for GTM (DoNotMerge) Nov 15, 2018

Fixing example names

293f285

wilcobmsft requested changes Nov 16, 2018

View reviewed changes

jhendrixMSFT requested changes Nov 16, 2018

View reviewed changes

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 16, 2018

ARM feedback on datetime

4b98cb6

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 20, 2018

muazmian reviewed Nov 21, 2018

View reviewed changes

Azure deleted a comment from openapi-portal-comment bot Nov 30, 2018

jhendrixMSFT closed this Nov 30, 2018

sandeepkatumalla mentioned this pull request Mar 19, 2019

[Hub Generated] Review request for Microsoft.Consumption to add version 2018-11-01-preview #5429

Merged

2 tasks

wilcobmsft mentioned this pull request Mar 19, 2019

Add GTM APIs. #5423

Merged

5 tasks

Conversation

sandeepkatumalla commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

Uh oh!

AutorestCI commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

dsgouda commented Nov 15, 2018

Uh oh!

This comment was marked as outdated.

Uh oh!

wilcobmsft Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Nov 16, 2018

Uh oh!

sandeepkatumalla commented Nov 16, 2018 via email

Uh oh!

ravbhatnagar commented Nov 20, 2018

Uh oh!

ravbhatnagar commented Nov 20, 2018

Uh oh!

muazmian Nov 21, 2018

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Nov 30, 2018

Uh oh!

sandeepkatumalla commented Nov 30, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sandeepkatumalla commented Nov 15, 2018 •

edited

Loading

AutorestCI commented Nov 15, 2018 •

edited

Loading

AutorestCI commented Nov 15, 2018 •

edited

Loading

AutorestCI commented Nov 15, 2018 •

edited

Loading